[brlcad-devel] Issue with HRT and HYP primitive ported to OpenCL

Discussion:

Shailesh Tripathi

2017-04-03 12:54:59 UTC

Hello,
I ported the HRT primitive to OpenCL, but I was getting a blank screen
while running the raytracer. To cross validate the error, I ported HYP
primitive too. But I am getting the same issue ,viz., (just before "
*OCLPREP:" ) *

* (nil) free ERRORbu_pool_delete*

Please check what can be the possible issues.
https://sourceforge.net/p/brlcad/patches/459/

Regards
Shailesh

Shailesh Tripathi
B.Tech. Part-IV
Electronics Engineering
IIT-BHU (Varanasi)

Vasco Alexandre da Silva Costa

2017-04-03 23:14:44 UTC

Permalink

On Mon, Apr 3, 2017 at 1:54 PM, Shailesh Tripathi <

Post by Shailesh Tripathi
Hello,
I ported the HRT primitive to OpenCL, but I was getting a blank screen
while running the raytracer. To cross validate the error, I ported HYP
primitive too. But I am getting the same issue ,viz., (just before "
*OCLPREP:" ) *

* (nil) free ERRORbu_pool_delete*

Please check what can be the possible issues.
https://sourceforge.net/p/brlcad/patches/459/

hrt_shot() isn't being called from anywhere. You missed some of the glue
code. e.g. see rl.cl.

Regards,

--
Vasco Alexandre da Silva Costa
PhD in Computer Engineering (Computer Graphics)
Instituto Superior TÃ©cnico/University of Lisbon, Portugal

Vasco Alexandre da Silva Costa

2017-04-03 23:16:16 UTC

Permalink

On Tue, Apr 4, 2017 at 12:14 AM, Vasco Alexandre da Silva Costa <

Post by Vasco Alexandre da Silva Costa
On Mon, Apr 3, 2017 at 1:54 PM, Shailesh Tripathi <

* (nil) free ERRORbu_pool_delete*

Please check what can be the possible issues.
https://sourceforge.net/p/brlcad/patches/459/

hrt_shot() isn't being called from anywhere. You missed some of the glue
code. e.g. see rl.cl.

PS: Of course I meant 'src/librt/primitives/rt.cl'. Duh. :-)

Regards,

--
Vasco Alexandre da Silva Costa
PhD in Computer Engineering (Computer Graphics)
Instituto Superior TÃ©cnico/University of Lisbon, Portugal

Shailesh Tripathi

2017-04-05 19:30:33 UTC

Permalink

Hello,
I forgot to define ID_HRT. So i added:
#define ID_HRT 32
in rt.cl file.
Do I need to make any more changes to invoke hrt_shot() as I am getting a
blank screen on the frame buffer.( though the previous error bu_pool_delete
is gone now) the rest of the log looks fine.

Regards
Shailesh
On Apr 4, 2017 4:46 AM, "Vasco Alexandre da Silva Costa" <

Post by Vasco Alexandre da Silva Costa
On Tue, Apr 4, 2017 at 12:14 AM, Vasco Alexandre da Silva Costa <

Post by Vasco Alexandre da Silva Costa
On Mon, Apr 3, 2017 at 1:54 PM, Shailesh Tripathi <

* (nil) free ERRORbu_pool_delete*

Please check what can be the possible issues.
https://sourceforge.net/p/brlcad/patches/459/

hrt_shot() isn't being called from anywhere. You missed some of the glue
code. e.g. see rl.cl.

PS: Of course I meant 'src/librt/primitives/rt.cl'. Duh. :-)
Regards,
--
Vasco Alexandre da Silva Costa
PhD in Computer Engineering (Computer Graphics)
Instituto Superior TÃ©cnico/University of Lisbon, Portugal
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
BRL-CAD Developer mailing list
https://lists.sourceforge.net/lists/listinfo/brlcad-devel

Shailesh Tripathi

2017-04-07 16:31:04 UTC

Permalink

What could be the error now?
On Apr 6, 2017 1:00 AM, "Shailesh Tripathi" <

Post by Shailesh Tripathi
Hello,
#define ID_HRT 32
in rt.cl file.
Do I need to make any more changes to invoke hrt_shot() as I am getting a
blank screen on the frame buffer.( though the previous error bu_pool_delete
is gone now) the rest of the log looks fine.
Regards
Shailesh
On Apr 4, 2017 4:46 AM, "Vasco Alexandre da Silva Costa" <

Post by Vasco Alexandre da Silva Costa
On Tue, Apr 4, 2017 at 12:14 AM, Vasco Alexandre da Silva Costa <

Post by Vasco Alexandre da Silva Costa
On Mon, Apr 3, 2017 at 1:54 PM, Shailesh Tripathi <

* (nil) free ERRORbu_pool_delete*

Please check what can be the possible issues.
https://sourceforge.net/p/brlcad/patches/459/

hrt_shot() isn't being called from anywhere. You missed some of the glue
code. e.g. see rl.cl.

Vasco Alexandre da Silva Costa

2017-04-07 19:30:06 UTC

Permalink

You got a patch?

On Fri, Apr 7, 2017 at 5:31 PM, Shailesh Tripathi <

Post by Shailesh Tripathi
What could be the error now?

Post by Vasco Alexandre da Silva Costa
On Tue, Apr 4, 2017 at 12:14 AM, Vasco Alexandre da Silva Costa <

Post by Vasco Alexandre da Silva Costa
On Mon, Apr 3, 2017 at 1:54 PM, Shailesh Tripathi <

* (nil) free ERRORbu_pool_delete*

Please check what can be the possible issues.
https://sourceforge.net/p/brlcad/patches/459/

hrt_shot() isn't being called from anywhere. You missed some of the
glue code. e.g. see rl.cl.

------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
BRL-CAD Developer mailing list
https://lists.sourceforge.net/lists/listinfo/brlcad-devel

--
Vasco Alexandre da Silva Costa
PhD in Computer Engineering (Computer Graphics)
Instituto Superior TÃ©cnico/University of Lisbon, Portugal

Shailesh Tripathi

2017-04-07 22:13:42 UTC

Permalink

Hello,
PFA the link for the patch for HRT primitive:
https://sourceforge.net/p/brlcad/patches/459/

Also, I added the line

*#define ID_HRT 32*

in rt.cl file.

But I am getting a blank screen in the buffer frame.

Regards
Shailesh

Shailesh Tripathi
B.Tech. Part-IV
Electronics Engineering
IIT-BHU (Varanasi)

On Sat, Apr 8, 2017 at 1:00 AM, Vasco Alexandre da Silva Costa <

You got a patch?
On Fri, Apr 7, 2017 at 5:31 PM, Shailesh Tripathi <

Post by Shailesh Tripathi
What could be the error now?
On Apr 6, 2017 1:00 AM, "Shailesh Tripathi" <

Post by Shailesh Tripathi
Hello,
#define ID_HRT 32
in rt.cl file.
Do I need to make any more changes to invoke hrt_shot() as I am getting
a blank screen on the frame buffer.( though the previous error
bu_pool_delete is gone now) the rest of the log looks fine.
Regards
Shailesh
On Apr 4, 2017 4:46 AM, "Vasco Alexandre da Silva Costa" <

Post by Vasco Alexandre da Silva Costa
On Tue, Apr 4, 2017 at 12:14 AM, Vasco Alexandre da Silva Costa <

Post by Vasco Alexandre da Silva Costa
On Mon, Apr 3, 2017 at 1:54 PM, Shailesh Tripathi <

Post by Shailesh Tripathi
Hello,
I ported the HRT primitive to OpenCL, but I was getting a blank
screen while running the raytracer. To cross validate the error, I ported
HYP primitive too. But I am getting the same issue ,viz., (just before "
*OCLPREP:" ) *

* (nil) free ERRORbu_pool_delete*

Please check what can be the possible issues.
https://sourceforge.net/p/brlcad/patches/459/

hrt_shot() isn't being called from anywhere. You missed some of the
glue code. e.g. see rl.cl.

--
Vasco Alexandre da Silva Costa
PhD in Computer Engineering (Computer Graphics)
Instituto Superior TÃ©cnico/University of Lisbon, Portugal
------------------------------------------------------------
------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
BRL-CAD Developer mailing list
https://lists.sourceforge.net/lists/listinfo/brlcad-devel

Vasco Alexandre da Silva Costa

2017-04-08 06:23:01 UTC

Permalink

That patch on sf.net is six days old. I thought you made changes to it? I
already reviewed the original patch on April 4th.

On Fri, Apr 7, 2017 at 11:13 PM, Shailesh Tripathi <

Post by Shailesh Tripathi
Hello,
https://sourceforge.net/p/brlcad/patches/459/
Also, I added the line

*#define ID_HRT 32*

in rt.cl file.
But I am getting a blank screen in the buffer frame.
Regards
Shailesh
Shailesh Tripathi
B.Tech. Part-IV
Electronics Engineering
IIT-BHU (Varanasi)
On Sat, Apr 8, 2017 at 1:00 AM, Vasco Alexandre da Silva Costa <

You got a patch?
On Fri, Apr 7, 2017 at 5:31 PM, Shailesh Tripathi <

Post by Shailesh Tripathi
What could be the error now?
On Apr 6, 2017 1:00 AM, "Shailesh Tripathi" <

Post by Shailesh Tripathi
Hello,
#define ID_HRT 32
in rt.cl file.
Do I need to make any more changes to invoke hrt_shot() as I am getting
a blank screen on the frame buffer.( though the previous error
bu_pool_delete is gone now) the rest of the log looks fine.
Regards
Shailesh
On Apr 4, 2017 4:46 AM, "Vasco Alexandre da Silva Costa" <

Post by Vasco Alexandre da Silva Costa
On Tue, Apr 4, 2017 at 12:14 AM, Vasco Alexandre da Silva Costa <

Post by Vasco Alexandre da Silva Costa
On Mon, Apr 3, 2017 at 1:54 PM, Shailesh Tripathi <

Post by Shailesh Tripathi
Hello,
I ported the HRT primitive to OpenCL, but I was getting a blank
screen while running the raytracer. To cross validate the error, I ported
HYP primitive too. But I am getting the same issue ,viz., (just before "
*OCLPREP:" ) *

* (nil) free ERRORbu_pool_delete*

Please check what can be the possible issues.
https://sourceforge.net/p/brlcad/patches/459/

hrt_shot() isn't being called from anywhere. You missed some of the
glue code. e.g. see rl.cl.

--
Vasco Alexandre da Silva Costa
PhD in Computer Engineering (Computer Graphics)
Instituto Superior TÃ©cnico/University of Lisbon, Portugal

Shailesh Tripathi

2017-04-08 12:18:22 UTC

Permalink

As I said,

Post by Shailesh Tripathi
Also, I added the line

*#define ID_HRT 32*

in rt.cl file.

Please consider this too.

Regards
Shailesh

Shailesh Tripathi
B.Tech. Part-IV
Electronics Engineering
IIT-BHU (Varanasi)

On Sat, Apr 8, 2017 at 11:53 AM, Vasco Alexandre da Silva Costa <

Post by Shailesh Tripathi
That patch on sf.net is six days old. I thought you made changes to it? I
already reviewed the original patch on April 4th.
On Fri, Apr 7, 2017 at 11:13 PM, Shailesh Tripathi <

Hello,
https://sourceforge.net/p/brlcad/patches/459/
Also, I added the line

*#define ID_HRT 32*

in rt.cl file.
But I am getting a blank screen in the buffer frame.
Regards
Shailesh
Shailesh Tripathi
B.Tech. Part-IV
Electronics Engineering
IIT-BHU (Varanasi)
On Sat, Apr 8, 2017 at 1:00 AM, Vasco Alexandre da Silva Costa <

You got a patch?
On Fri, Apr 7, 2017 at 5:31 PM, Shailesh Tripathi <

Post by Shailesh Tripathi
What could be the error now?
On Apr 6, 2017 1:00 AM, "Shailesh Tripathi" <

Post by Shailesh Tripathi
Hello,
#define ID_HRT 32
in rt.cl file.
Do I need to make any more changes to invoke hrt_shot() as I am
getting a blank screen on the frame buffer.( though the previous error
bu_pool_delete is gone now) the rest of the log looks fine.
Regards
Shailesh
On Apr 4, 2017 4:46 AM, "Vasco Alexandre da Silva Costa" <

Post by Vasco Alexandre da Silva Costa
On Tue, Apr 4, 2017 at 12:14 AM, Vasco Alexandre da Silva Costa <

Post by Vasco Alexandre da Silva Costa
On Mon, Apr 3, 2017 at 1:54 PM, Shailesh Tripathi <

Post by Shailesh Tripathi
Hello,
I ported the HRT primitive to OpenCL, but I was getting a blank
screen while running the raytracer. To cross validate the error, I ported
HYP primitive too. But I am getting the same issue ,viz., (just before "
*OCLPREP:" ) *

* (nil) free ERRORbu_pool_delete*

Please check what can be the possible issues.
https://sourceforge.net/p/brlcad/patches/459/

hrt_shot() isn't being called from anywhere. You missed some of the
glue code. e.g. see rl.cl.

Christopher Sean Morrison

2017-04-08 16:16:18 UTC

Permalink

Post by Shailesh Tripathi
As I said,
Also, I added the line
#define ID_HRT 32
in rt.cl <http://rt.cl/> file.
Please consider this too.

This is not a significant change. If thatâs all you changed, then thereâs no reason to believe the output will be any different (compilation might succeed where it previously might not, that is all), no? If thereâs something else to consider, please be more detailed or keep debugging until you run out of ideas.

Note that one of the points about submitting code changes is to see how you work as a developer. A good open source dev makes useful independent progress, communicates frequently, and knows when to ask for help.

Itâs a careful balance of asking for help when you are truly stuck (which you should do) and asking others to do something prematurely (e.g., asking questions without researching the answer oneself is always a bad idea). Iâm not saying youâre doing that here, but seeing a flurry of short 1-sentence e-mails usually implies inefficient, incomplete miscommunication. Itâs good to see progress on your porting, but make sure youâre not taking up other peopleâs time unnecessarily (as they should do the same to you and everyone else to each other).

Cheers!
Sean

Vasco Alexandre da Silva Costa

2017-04-08 17:31:23 UTC

Permalink

I believed I said this before, but look at one of the patches Param Hanji
made last year to get an idea of what needs to be done.
You're lacking quite a lot of glue code. Like I said 4 days ago, hrt_shot()
isn't being called anywhere in the OpenCL code, adding a #define ain't
gonna fix that.

Regards,

On Sat, Apr 8, 2017 at 7:23 AM, Vasco Alexandre da Silva Costa <

Post by Vasco Alexandre da Silva Costa
That patch on sf.net is six days old. I thought you made changes to it? I
already reviewed the original patch on April 4th.
On Fri, Apr 7, 2017 at 11:13 PM, Shailesh Tripathi <

Post by Shailesh Tripathi
Hello,
https://sourceforge.net/p/brlcad/patches/459/
Also, I added the line

*#define ID_HRT 32*

in rt.cl file.
But I am getting a blank screen in the buffer frame.
Regards
Shailesh
Shailesh Tripathi
B.Tech. Part-IV
Electronics Engineering
IIT-BHU (Varanasi)
On Sat, Apr 8, 2017 at 1:00 AM, Vasco Alexandre da Silva Costa <

You got a patch?
On Fri, Apr 7, 2017 at 5:31 PM, Shailesh Tripathi <

Post by Shailesh Tripathi
What could be the error now?
On Apr 6, 2017 1:00 AM, "Shailesh Tripathi" <

Post by Shailesh Tripathi
Hello,
#define ID_HRT 32
in rt.cl file.
Do I need to make any more changes to invoke hrt_shot() as I am
getting a blank screen on the frame buffer.( though the previous error
bu_pool_delete is gone now) the rest of the log looks fine.
Regards
Shailesh
On Apr 4, 2017 4:46 AM, "Vasco Alexandre da Silva Costa" <

Post by Vasco Alexandre da Silva Costa
On Tue, Apr 4, 2017 at 12:14 AM, Vasco Alexandre da Silva Costa <

Post by Vasco Alexandre da Silva Costa
On Mon, Apr 3, 2017 at 1:54 PM, Shailesh Tripathi <

Post by Shailesh Tripathi
Hello,
I ported the HRT primitive to OpenCL, but I was getting a blank
screen while running the raytracer. To cross validate the error, I ported
HYP primitive too. But I am getting the same issue ,viz., (just before "
*OCLPREP:" ) *

* (nil) free ERRORbu_pool_delete*

Please check what can be the possible issues.
https://sourceforge.net/p/brlcad/patches/459/

hrt_shot() isn't being called from anywhere. You missed some of the
glue code. e.g. see rl.cl.

--
Vasco Alexandre da Silva Costa
PhD in Computer Engineering (Computer Graphics)
Instituto Superior TÃ©cnico/University of Lisbon, Portugal

Shailesh Tripathi

2017-04-08 22:29:32 UTC

Permalink

Hello,

Post by Shailesh Tripathi
Do I need to make any more changes to invoke hrt_shot() as I am getting a
blank screen on the frame buffer.( *though the previous error
bu_pool_delete is gone now*) the rest of the log looks fine.

Like I said that error *"(nil) free ERRORbu_pool_delete" *is gone now after
making the changes in the rt.cl file. This makes me feel that the*
hrt_shot() *function is being invoked. But since Vasco Sir asked for the
patch, I felt it beneficial to just highlight the changes make( 3 lines for
the addition of ID_HRT) in the code) instead of making the complete new
patch. As it went unnoticed I added one line mail for that.

I am not saying that correct my error, but I am asking of how can I find my
errors. Since I am new to the software and gdb, I don't know how to debug
it. Anything that can help me understand my error is helpful.

Yes I considered the *"part" *patch and felt that I made the necessary
changes.
It would be a lot help if someone could help me with the debugging.
I apologize for my unprofessional behaviour, but my curiousness to get the
patch working made me flush the list with mails.

Regards
Shailesh

Shailesh Tripathi
B.Tech. Part-IV
Electronics Engineering
IIT-BHU (Varanasi)

On Sat, Apr 8, 2017 at 11:01 PM, Vasco Alexandre da Silva Costa <

Post by Shailesh Tripathi
I believed I said this before, but look at one of the patches Param Hanji
made last year to get an idea of what needs to be done.
You're lacking quite a lot of glue code. Like I said 4 days ago,
hrt_shot() isn't being called anywhere in the OpenCL code, adding a #define
ain't gonna fix that.
Regards,
On Sat, Apr 8, 2017 at 7:23 AM, Vasco Alexandre da Silva Costa <

Post by Vasco Alexandre da Silva Costa
That patch on sf.net is six days old. I thought you made changes to it?
I already reviewed the original patch on April 4th.
On Fri, Apr 7, 2017 at 11:13 PM, Shailesh Tripathi <

Post by Shailesh Tripathi
Hello,
https://sourceforge.net/p/brlcad/patches/459/
Also, I added the line

*#define ID_HRT 32*

in rt.cl file.
But I am getting a blank screen in the buffer frame.
Regards
Shailesh
Shailesh Tripathi
B.Tech. Part-IV
Electronics Engineering
IIT-BHU (Varanasi)
On Sat, Apr 8, 2017 at 1:00 AM, Vasco Alexandre da Silva Costa <

You got a patch?
On Fri, Apr 7, 2017 at 5:31 PM, Shailesh Tripathi <

Post by Shailesh Tripathi
What could be the error now?
On Apr 6, 2017 1:00 AM, "Shailesh Tripathi" <

Post by Shailesh Tripathi
Hello,
#define ID_HRT 32
in rt.cl file.
Do I need to make any more changes to invoke hrt_shot() as I am
getting a blank screen on the frame buffer.( though the previous error
bu_pool_delete is gone now) the rest of the log looks fine.
Regards
Shailesh
On Apr 4, 2017 4:46 AM, "Vasco Alexandre da Silva Costa" <

Post by Vasco Alexandre da Silva Costa
On Tue, Apr 4, 2017 at 12:14 AM, Vasco Alexandre da Silva Costa <

Post by Vasco Alexandre da Silva Costa
On Mon, Apr 3, 2017 at 1:54 PM, Shailesh Tripathi <

Post by Shailesh Tripathi
Hello,
I ported the HRT primitive to OpenCL, but I was getting a blank
screen while running the raytracer. To cross validate the error, I ported
HYP primitive too. But I am getting the same issue ,viz., (just before "
*OCLPREP:" ) *

* (nil) free ERRORbu_pool_delete*

Please check what can be the possible issues.
https://sourceforge.net/p/brlcad/patches/459/

hrt_shot() isn't being called from anywhere. You missed some of the
glue code. e.g. see rl.cl.

--
Vasco Alexandre da Silva Costa
PhD in Computer Engineering (Computer Graphics)
Instituto Superior TÃ©cnico/University of Lisbon, Portugal